Repository navigation
Conversation
Xeeynamo
reviewed
Oct 13, 2026
Xeeynamo
left a comment
Xeeynamo
left a comment
Owner
There was a problem hiding this comment.
A few changes needed:
- All
D_80062D98checks must do an early return, instead of nesting the whole function inside anif - Some
whileloops I'd suggest attempting to convert asforloops - need a rebase
I'd be good to also import data and assets out of those magic overlays, not only getting the code decompiled. Otherwise they are not really 100% complete.
khasinski
force-pushed
the
magic-ten-overlays
branch
from
October 13, 2026 23:06
b767bbf to
7634ea8
Compare
eduardovra
reviewed
Oct 14, 2026
khasinski
force-pushed
the
magic-ten-overlays
branch
from
October 14, 2026 00:44
2c70381 to
ca2dc68
Compare
Xeeynamo
requested changes
Oct 14, 2026
Xeeynamo
left a comment
Xeeynamo
left a comment
Owner
There was a problem hiding this comment.
Requesting a few more changes. I know I mentioned importing data and assets for the magic files. But I think it would have been better to have done that in a separate PR, so it's much easier for me to review. We do not want to have PRs that keep growing in scope review after review.
khasinski
force-pushed
the
magic-ten-overlays
branch
from
October 19, 2026 17:31
ca2dc68 to
13b3ebc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Imports and decompiles ten MAGIC overlays:
GATTAI,JINRAI,SMKBALL,THREAT,TEARS,ECHOES,MAGEND,HAKAI,BOOST, andMINIMAM.